yarnpkg/yarn

yarn publish changes version with wrong password

Open

#1,675 opened on 2016年11月4日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)JavaScript (41,514 stars) (2,731 forks)batch import
cat-buggood first issuehelp wantedtriaged

説明

Do you want to request a feature or report a bug? Bug

What is the current behavior? Yarn will refuse to publish a package if the version doesn't change:

error New version is the same as the current version.

It also bumps the version before logging in, so if auth fails, you'll be in an error state.

If the current behavior is a bug, please provide the steps to reproduce.

yarn publish
// enter new version
// enter wrong npm password
error Incorrect username or password.
yarn publish
error New version is the same as the current version.

What is the expected behavior? yarn publish should only error if the version currently posted on npmjs.org is the same as the version in package.json

Please mention your node.js, yarn and operating system version. yarn publish v0.15.1 node v6.2.1 macOS 10.11.6

コントリビューターガイド

技術スタック
javascriptnodejs
領域
clirelease
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
JavaScriptNode.jsnpm publishingYarn internals
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
Investigate the publish command's flow in the source code, likely in `src/cli/commands/publish.js` or similar. The version bump should occur only after successful authentication with the npm registry. Check the order of operations and ensure that the version is not updated if authentication fails. Look at the error handling and consider adding a check before modifying package.json.