xtermjs/xterm.js

Issue in Linkifier2._removeIntersectingLinks

オープン

#4,296 opened on 2022/12/08

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)TypeScript (1,574 件のフォーク)batch import
area/linkshelp wantedtype/bug

Repository metrics

Stars
 (16,196 個のスター)
PR merge metrics
 (平均マージ 2d 10h) (30d で 16 merged PRs)

説明

Coming from https://github.com/xtermjs/xterm.js/pull/4288.

There is an issue with the private method Linkifier2._removeIntersectingLinks not correctly respecting multiple wrapped links in one merged line, which leads to wrong removal of later links.

On a first look it seems the method does not account y-progression, thus later links are mistaken as overlapping from their column position only.

コントリビューターガイド