xtermjs/xterm.js
GitHub で見るAuto fit addon doesn't work when parent element uses border-box
Open
#1,283 opened on 2018年2月12日
area/addon/fitgood first issuehelp wantedtype/bug
Repository metrics
- Stars
- (16,196 stars)
- PR merge metrics
- (平均マージ 2d 10h) (30d で 16 merged PRs)
説明
The calculations for height and width of the parent in the auto fit plugin are incorrect when the parent element uses box-sizing: border-box. This is because the computed height includes the padding but the content does not.
The right implementation might be to get the client height of the parent element using gBCR and then subtract the parent padding.
/CC @taion