Auto fit addon doesn't work when parent element uses border-box · xtermjs/xterm.js#1283

(4 comments) (0 reactions) (1 assignee)TypeScript (16,196 stars) (1,574 forks)batch import

area/addon/fitgood first issuehelp wantedtype/bug

説明

The calculations for height and width of the parent in the auto fit plugin are incorrect when the parent element uses box-sizing: border-box. This is because the computed height includes the padding but the content does not.

The right implementation might be to get the client height of the parent element using gBCR and then subtract the parent padding.

/CC @taion

技術スタック: typescriptcss
領域: frontend
Issue 種別: bug
難度: 3
推定時間: half day
活動状況: blocked
明確さ: clear
前提条件: CSS box sizingJavaScriptxterm.js addon conventions
初心者向け度: 40
調査方針: The issue is in the fit addon's fit.ts file (lines 30-31) where the computed height and width are incorrect when the parent uses border box. The fix involves using getBoundingClientRect (gBCR) to get the client height and width, then subtracting the parent padding. Implement this change in the fit function. Ensure tests pass and verify with a parent that has box sizing: border box.