xgfe/react-native-datepicker

Please put example code in sub directory

Open

#81 opened on 2017年2月9日

GitHub で見る
 (2 comments) (2 reactions) (0 assignees)JavaScript (2,109 stars) (737 forks)batch import
enhancementhelp wanted

説明

Hi, thanks for the great work. When I initially saw your codebase, I thought this was a React Native bridge module, but then came to understand it was a JS-only package. This is because I saw the android and ios directories. Also I was confused at index.ios.js and index.android.js files.

Typically in a RN library you put example code in a sub directory called Example or whatever. This will eliminate any confusion. If you need help, let me know and I'll create a PR for it

コントリビューターガイド

技術スタック
react nativejavascriptandroidios
領域
mobile
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Familiarity with React Native project structureBasic knowledge of file organization
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
90
調査方針
First, examine the repository's root directory structure to locate existing example files (e.g., index.ios.js, index.android.js) and the android/ and ios/ directories. Then create an 'Example' subdirectory and move those files into it. Update any import paths within the moved files to reflect the new location. Also check the README or other documentation for references to the example code and update those paths accordingly. Ensure the example still works after the move.