character value auto comments on ASCII for PUSH and copy mnemonic from comments · x64dbg/x64dbg#1167

(0 comments) (0 reactions) (0 assignees)C++ (48,381 stars) (2,734 forks)batch import

enhancementgood first issue

説明

Good morning, I recently asked for get in the comment the printable chars of the cmp instructions. This feature it's implemented and it's very nice.
https://github.com/x64dbg/x64dbg/issues/1132 Actually I am debugging a shellcode and I think could be useful having also the push instruction commented. Like in the image you can see the string kernel32.dll is pushed. 226611359_78645_15528557412368967432

Finally, I found a bug "bug" that you cannot copy the comments from mnemonic. So if you have it enable and you copy the selection, the comment of mnemonic it's not copied.

Have a nice day :+1:

コントリビューターガイド

技術スタック: cpp
領域: desktop
Issue 種別: feature
難度: 3
推定時間: half day
活動状況: stale
明確さ: mostly clear
前提条件: C++assemblyfamiliarity with x64dbg internals
初心者向け度: 35
調査方針: Examine the existing implementation for ASCII comments on cmp instructions (issue #1132) and replicate it for push instructions. For the copy bug, review the disassembly view's copy handler to ensure mnemonics with comments are included in copied text.