withastro/astro

🐛 BUG: version 2.8.1 removes trailing comma on save

クロヌズ

#14,665 opened on 2024/03/29

 (7 件のコメント) (0 件のリアクション) (0 人の担圓者)TypeScript (3,720 件のフォヌク)batch import
good first issuepkg: language-tools

Repository metrics

Stars
 (61,855 個のスタヌ)
PR merge metrics
 (平均マヌゞ 4d 23h) (30d で 197 merged PRs)

説明

Describe the Bug

When I save an astro file, it removes trailing commas from multi-line function calls.

If I downgrade to version 2.8.0 and save, it adds them back again when I save.

I wonder if it is also related to withastro/language-tools#823 - I found another issue that sounded like it was similarly affected, withastro/language-tools#829 - though the specific fix for that one did not address this one.

Steps to Reproduce

  1. Open any .astro file with multi-line function calls. E.g.
    foo(
      var1,
      var2,
    );
    
  2. save the file
  3. trailing commas are removed. For the above example it would change to:
    foo(
      var1,
      var2
    );
    

EDIT: After comments, here is a better example, since the above ends up on a single line which does not have trailing comma:

  someReallyLongNAmeThingThatIsReallyLong(
    someReallyLongVarThatISLongAnd,
    SomeOtherReallyLongThing,
  );

コントリビュヌタヌガむド