winstonjs/winston

File logging reconfiguration issue (Error: write after end)

Open

#1,573 opened on 2019年1月23日

GitHub で見る
 (33 comments) (18 reactions) (0 assignees)JavaScript (21,967 stars) (1,789 forks)batch import
BugGood First IssueHelp WantedImportant

説明

Please tell us about your environment:

  • winston version?
    • winston@2
    • [ X] winston@3
  • _node -v outputs:_v10.15.0
  • _Operating System?_Windows 10
  • _Language? JavaScript (pure Node)

What is the problem?

When logger is reconfigured, the open streams are destroyed and winston tries to write to an already destroyed stream.

I created a really simple playground to replicate it (less than 10 lines of actual code): https://github.com/peterbakonyi05/winston-log-rotate-reconfiguration-issue/blob/master/index.js

What do you expect to happen instead?

winston creates a new stream and handles reconfiguration.

Note

Alternatively, instead of reconfiguring winston a new instance can be created, in case someone else has the same issue. Just call .close on the old instance and create a new from scratch.

コントリビューターガイド

技術スタック
nodejsjavascript
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Basic Node.js knowledgeUnderstanding of streams
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
The issue describes a bug where reconfiguring a winston logger causes a 'write after end' error because open streams are destroyed. The reproduction is at https://github.com/peterbakonyi05/winston log rotate reconfiguration issue/blob/master/index.js. To fix this, investigate winston's Logger.prototype.configure method in the lib/winston/logger.js file and how it handles stream cleanup and reinitialization. The discussion in the issue may contain additional insights.
File logging reconfiguration issue (Error: write after end) · winstonjs/winston#1573 | Good First Issue