winstonjs/winston

File logging reconfiguration issue (Error: write after end)

オープン

#1,573 opened on 2019/01/23

 (34 件のコメント) (18 件のリアクション) (0 人の担当者)JavaScript (1,789 件のフォーク)batch import
BugGood First IssueHelp WantedImportant

Repository metrics

Stars
 (21,967 個のスター)
PR merge metrics
 (平均マージ 68d 4h) (30d で 9 merged PRs)

説明

Please tell us about your environment:

  • winston version?
    • winston@2
    • [ X] winston@3
  • _node -v outputs:_v10.15.0
  • _Operating System?_Windows 10
  • _Language? JavaScript (pure Node)

What is the problem?

When logger is reconfigured, the open streams are destroyed and winston tries to write to an already destroyed stream.

I created a really simple playground to replicate it (less than 10 lines of actual code): https://github.com/peterbakonyi05/winston-log-rotate-reconfiguration-issue/blob/master/index.js

What do you expect to happen instead?

winston creates a new stream and handles reconfiguration.

Note

Alternatively, instead of reconfiguring winston a new instance can be created, in case someone else has the same issue. Just call .close on the old instance and create a new from scratch.

コントリビューターガイド