whatwg/html

Small clarity improvements to canvas transform methods

オープン

#2,848 opened on 2017/07/19

 (7 件のコメント) (1 件のリアクション) (0 人の担当者)HTML (2,520 件のフォーク)batch import
clarificationgood first issuetopic: canvas

Repository metrics

Stars
 (7,654 個のスター)
PR merge metrics
 (平均マージ 42d 18h) (30d で 22 merged PRs)

説明

While in the area for #2845, I noticed the following small tweaks that we could make to improve that section of the spec:

  • Replace "abort these steps" with "return" everywhere. (The latter is a more modern convention, per Infra.)
  • Link "multiplying" in the definition of transform(a, b, c, d, e, f) to https://drafts.fxtf.org/geometry/#matrix-multiply
  • Re-do setTransform(a, b, c, d, e, f) steps 2-3 to reset the current transformation matrix to the appropriate matrix (a c e / b d f / 0 0 1), instead of resetting the matrix to the identity matrix then invoking the transform() method. It's bad practice to invoke methods from other methods.

This is a good first bug :)

コントリビューターガイド