wevm/frog

Root element `width` and `height` don't match `imageAspectRatio` unless set explicitly

オープン

#502 opened on 2024/10/15

 (1 件のコメント) (0 件のリアクション) (1 人の担当者)TypeScript (97 件のフォーク)user submission
Good First IssueP: LowT: Bug

Repository metrics

Stars
 (440 個のスター)
PR merge metrics
 (平均マージ 1h 6m) (30d で 71 merged PRs)

説明

Describe the bug

This issue is likely related to #463

In this example, the text will overflow the square frame container. While the frame itself displays as square, the content inside it presumably takes up the width and height of a frame with a rectangular aspect ratio even though width and height are set to 100%.

app.frame("/test", async (c) => {
  return c.res({
    image: (
      <div
        style={{
          color: "white",
          display: "flex",
          fontSize: 60,
          width: "100%",
          height: "100%",
        }}
      >
        This is a really long line of text that overflows the square frame image
        because width and height were not set
      </div>
    ),
    imageAspectRatio: "1:1",
    // Uncommenting this fixes the issue
    // imageOptions: {
    //   width: 1200,
    //   height: 1200,
    // },
  });
});

image

Link to Minimal Reproducible Example

No response

Steps To Reproduce

Frog Version

0.17.4

TypeScript Version

No response

Check existing issues

Anything else?

No response

コントリビューターガイド