welldone-software/why-did-you-render

Show line where hook that changed is used (feature request)

Open

#191 opened on 2021年4月27日

GitHub で見る
 (3 comments) (4 reactions) (0 assignees)JavaScript (10,560 stars) (188 forks)batch import
enhancementgood first issuehelp wanted

説明

I currently have a very big hook, with dozens of useStates, lots of them have empty arrays which trigger unncesary re-renders. But I don't know which is the one doing it each time wdyr logs it's output. I get:

Re-rendered because of hook changes: 
[hook useState result]
...diff

When would be very useful for me is:

Re-rendered because of hook changes:
[hook useState result] (someRandomHook.ts:34)
...diff

Knowing which hook is changing would be useful, specially in nested hooks scenarios, for example I have a hook which uses a hook, and that internal one has state, but wdyr does not even specify which hook is that useState from (I guess react makes no distinction, it only cares about hook declaration order, so not sure how possible would this feature request be.)

コントリビューターガイド

技術スタック
javascriptreact
領域
performancedeveloper experience
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Understanding of React hooksFamiliarity with why did you render library source code
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
The issue requests to show the file and line number where a hook change originates. Start by examining the library's core files, particularly how it patches useState and other hooks (e.g., in src/monitorHooks.js or similar). Look for any existing stack trace collection or the ability to add Error().stack to capture the call site. Note that React does not naturally provide this info, but you could use a custom wrapper or monkey patch. Check if there are any comments or related PRs (none linked). A concrete approach: modify the hook patching to wrap the state setter with a function that captures the stack when called, then include that in the log output. Be aware of performance implications.