vizorvr/patches

Embed in user-page does not give functioning http://vizor.io instead just says /scripts/embed.js

オープン

#2,014 opened on 2017/07/01

 (5 件のコメント) (0 件のリアクション) (1 人の担当者)JavaScript (40 件のフォーク)github user discovery
BugEnhancementgood first issuehelp wanted

Repository metrics

Stars
 (205 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

current embed code generation in profile_view ( http://vizor.io/esaruoho -> select project -> tap on Share) is missing http://vizor.io at the start

compare to what was launched way back when ( https://twitter.com/vizor_vr/status/731213475037466625 - officially posted on 13th of May 2016 on Vizor_VR) - pasted image at 2017_07_01 11_26 pm

and you'll see that really, the embed code SHOULD be created with http://vizor.io/scripts/embed.js instead of only /scripts/embed.js

the user cannot be expected to figure this out on their own. (example of confused user: https://vizorvr.slack.com/archives/C0D7S35JQ/p1498874721217943 )

コントリビューターガイド