victorb/trymodule

Fix exec call to remove cache folder

オープン

#15 opened on 2016/03/29

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (31 件のフォーク)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (1,133 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

https://github.com/VictorBjelkholm/trymodule/blob/2030806d790213d426456959fdc7a69773a4c6f7/index.js#L59

Oh noes. Please don't. Never do string concat for commands, use execFile instead. Never pass environment variables directly to rm without sanitation, better yet, never spawn rm. Use a JS tools, like rimraf or even better del.

From: https://github.com/sindresorhus/awesome-nodejs/pull/477#event-606502245

コントリビューターガイド