vercel/hyper

To support a single cross-platform settings file some of the settings should be platform specific (like in VS Code)

Open

#2,584 opened on 2018年1月10日

GitHub で見る
 (0 comments) (9 reactions) (0 assignees)TypeScript (44,582 stars) (3,558 forks)batch import
good first issuehelp wanted💬 Feedback Wanted🛠 Type: Feature Request

説明

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: Windows 10 1709, Ubuntu 16.04, Ubuntu 17.10, macOS Sierra

  • Hyper.app version: 1.4.8

Feature Request

At present, with only a single "shell", "shellArgs", and "env" options I must maintain three different configs for the different OS platforms (where the only difference is in these three settings). This requires me to synchronize the rest of the settings manually in order to have the same experience across platforms. This kind of defeats the purpose of a cross-platform tool such as this.

VS Code gets around this problem by providing settings that are platform specific and the tool figures out which setting to use based on which platform it is running on. This is how I can have a single setting for VsCode that is shared across all machines.

In VS Code the relevant settings section looks like this:

"terminal.integrated.env.linux": {}, "terminal.integrated.env.osx": {}, "terminal.integrated.env.windows": {},

"terminal.integrated.shell.linux": "sh", "terminal.integrated.shell.osx": "sh", "terminal.integrated.shell.windows": "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe",

"terminal.integrated.shellArgs.linux": [], "terminal.integrated.shellArgs.osx": [ "-l" ], "terminal.integrated.shellArgs.windows": [],

Perhaps we could use:

shell.linux shellArgs.linux env.linux shell.windows

and so on.

コントリビューターガイド