valyala/fasthttp

Recommendation on cleaning of HostClient.

クローズ

#726 opened on 2020/01/12

 (2 件のコメント) (0 件のリアクション) (0 人の担当者)Go (1,755 件のフォーク)batch import
help wantedquestion

Repository metrics

Stars
 (21,741 個のスター)
PR merge metrics
 (平均マージ 3d) (30d で 44 merged PRs)

説明

As of now the only way to override Host header is to use HostClient as per Issue 318. This means we have to manage reusing/cleanup of HostClients ourselves which fasthttp.Client provided out of the box.

We will be writing something very similar to fasthttp.Client to handle this. Is it ok to remove the HostClient if it is not being used from more than MaxIdleConnDuration*2 or something, as we are sure all goroutines for individual connection cleaning would have run? We don't have access to connsCount as it is an unexported field and was modified to use connsCount instead of time.

if t.Sub(v.LastUseTime()) > (MaxIdleConnDuration*2) {
				delete(m, k)
			}

If not, what is the recommendation here?

コントリビューターガイド