valkey-io/valkey

Updated CI testing to improve catching tests early.

クローズ

#625 opened on 2024/06/11

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)C (1,138 件のフォーク)batch import
help wanted

Repository metrics

Stars
 (25,779 個のスター)
PR merge metrics
 (平均マージ 17d 7h) (30d で 74 merged PRs)

説明

We have had a recent string of issues with regressions being introduced into the daily rest run, that weren't being caught in the daily. After reviewing the daily failures, me and some other contributors came up with the following recommendation.

  1. Add in a second test suite that uses an allocator that is not jemalloc that has "no malloc size" enabled.
  2. Add a new CI target tests with TLS, but skip all of the "slow" tests. Included here is that we should add a slow tag to the payload fuzzer as they take a significant amount of time with TLS.
  3. Add a build target that actually builds the legacy unit test, to make sure they compile correctly.

We also discussed maybe adding in the sentinel tests as part of the build, however it wasn't clear if they regularly caught issues.

コントリビューターガイド