valkey-io/valkey-glide
Node: Test for protobuf internals should be part of internals tests and not client tests
オープン
#3,947 opened on 2025/05/22
Task 🔧good first issuenode 🐢testing 🧪
Repository metrics
- Stars
- (762 個のスター)
- PR merge metrics
- (PR metrics pending)
説明
Client tests are integration tests and not unit tests, testing of protobuf encoding should not be part of client tests, but part of the internal test, and should be moved to the right component of testing.
https://github.com/valkey-io/valkey-glide/blob/main/node/tests/GlideClient.test.ts#L95
Testing them inside the integration tests introduce importing of the glide code from specific files, in areas where the glide code should be tested as one piece, and introduces a door for errors of import export.