valkey-io/valkey-glide

Node: Reduce Non-Null Assertions about BaseClient's config

オープン

#2,679 opened on 2024/11/13

 (5 件のコメント) (0 件のリアクション) (2 人の担当者)Java (166 件のフォーク)auto 404
Task 🔧Users Paingood first issuenode 🐢

Repository metrics

Stars
 (762 個のスター)
PR merge metrics
 (平均マージ 7d 22h) (30d で 94 merged PRs)

説明

Description

I noticed that while the BaseClient constructor's options parameter is marked as optional (options?: BaseClientConfiguration), it's always provided with a non-null value in all creation paths through createClient()[1][2]. This creates an unnecessary nullable context that leads to multiple non-null assertions (!)[1][2][3] throughout the codebase.

This change would make the code more straightforward and remove potentially confusing null-checking context for developers first encountering the codebase. The nullable parameter currently serves no practical purpose since options are always provided during client creation.

Checklist

  • Make the options parameter required or give default value (e.g. {}) in the BaseClient constructor
  • Remove non-null assertions where this.config is used
  • Simplify the type safety guarantees

Additional Notes

No response

コントリビューターガイド