vaadin/framework

Deprecate MultiSelectionEvent.getNewSelection

オープン

#11,756 opened on 2019/10/23

 (1 件のコメント) (1 件のリアクション) (0 人の担当者)Java (715 件のフォーク)auto 404
Help wantedStale

Repository metrics

Stars
 (1,806 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Description copied from https://github.com/vaadin/flow/issues/6756

The class has three methods for the same thing:

Set<T> getValue()
Set<T> getAllSelectedItems()
Set<T> getNewSelection()

The first two are inherited, but getNewSelection exists only in MultiSelectionEvent.

Another reason to deprecate it is that the naming can cause confusion. We got feedback that a user expected the method to return the newly added items (compared to the old selection), i.e. what getAddedSelection returns.

JavaDocs should suggest to use getAllSelectedItems or getValue instead.

コントリビューターガイド