use-ink/ink

Add global clippy rules

Open

#886 opened on 2021年8月4日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)Rust (476 forks)github user discovery
B-enhancementgood first issue

Repository metrics

Stars
 (1,459 stars)
PR merge metrics
 (PR metrics pending)

説明

This issue is blocked by https://github.com/rust-lang/cargo/issues/5034.

We want to have some global clippy rules.

bool_assert_comparison

Allows syntax a la:

assert_eq!(flipper.get(), false);
assert_eq!(flipper.get(), true);

This is the bool_assert_comparison rule, which should be allowed.

With https://github.com/paritytech/ink/pull/884 we unfortunately had to change assert_eq!(flipper.get(), false); to assert!(!flipper.get());. These assert!(!…) expressions should be reverted to the boolean comparison.

new_without_default

For example, our flipper example in readme is currently no valid if you run clippy on it, since it misses a Default implementation for Flipper. This should not be necessary.

コントリビューターガイド