ueberdosis/tiptap

parseAttributes strips ids starting with number

Open

#7,345 opened on 2025年12月16日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)TypeScript (23,454 stars) (1,979 forks)batch import
area: coregood first issue

説明

Affected Packages

core, markdown

Version(s)

3.13

Bug Description

console.log(parseAttributes('#2123 .foo'))
console.log(parseAttributes('#hello .foo'))
console.log(parseAttributes('#5hello .foo'))

produces

{ class: 'foo' }
{ class: 'foo', id: 'hello' }
{ class: 'foo' }

As parseAttributes is used by default this affects all markdown parsing more or less, at least nodes created by the official helper utils.

Browser Used

Firefox

Code Example URL

No response

Expected Behavior

I.e. any id with a leading number gets stripped. Reading https://github.com/jgm/pandoc/issues/7920 i'm unsure what to conclude.

  1. If pandoc now allows ids to start with number, then it should be the same here
  2. If not, then a warning should be added here and elsewhere, as this behaviour is not necessariliy known to people.

Additional Context (Optional)

No response

Dependency Updates

  • Yes, I've updated all my dependencies.

コントリビューターガイド

技術スタック
typescriptjavascript
領域
frontend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
basic JavaScriptunderstanding of attribute parsing
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
75
調査方針
Investigate the `parseAttributes` function used in Tiptap's markdown utilities. The bug is that IDs starting with a number are stripped. Refer to the pandoc issue linked in the report for context. The fix likely involves modifying the attribute parsing logic in the core or markdown package to allow leading numbers in IDs or add a warning. Check the source code in the repository, specifically the parseAttributes implementation, and consider updating the regex or validation logic. No existing pull request or assignment, so this is open for a first time contributor.