Termination error messages do not follow standard GHC format · ucsd-progsys/liquidhaskell#1961

(1 comment) (0 reactions) (0 assignees)Haskell (1,306 stars) (157 forks)batch import

good first issue

説明

When checking tests/neg/AutoSize.hs, the folllowing is output:

**** LIQUID: UNSAFE ************************************************************

neg/AutoSize.hs:19:1: error:
    Termination Error
AutoSize.expSize
No decreasing parameter
   |
19 | expSize (EConst _) = 0
   | ^^^^^^^

Compare with:

**** LIQUID: UNSAFE ************************************************************

neg/Ast.hs:55:1: error:
    Liquid Type Mismatch
    .
    The inferred type
      VV : Ast.AstIndex
    .
    is not a subtype of the required type
      VV : {VV : Ast.AstIndex | Ast.isTypeIndex VV}
    .
    Constraint id 1
   |
55 | wrong = id1 astExpr
   |

and you can see the leading whitespace differences.

コントリビューターガイド

技術スタック: なし
領域: developer experience
Issue 種別: bug
難度: 1
推定時間: under 1 hour
活動状況: fresh
明確さ: clear
前提条件: basic Haskell knowledgefamiliarity with GHC error format
初心者向け度: 90
調査方針: The issue highlights a formatting inconsistency in termination error messages. Compare the output from `tests/neg/AutoSize.hs` with the standard GHC format shown in `neg/Ast.hs`. The fix involves adjusting the whitespace and possibly the structure of termination error output in LiquidHaskell's error reporting code. Locate the function responsible for generating termination errors and modify it to align with GHC's style. Refer to the LiquidHaskell source, likely in files related to error handling, and test with the provided examples.