uber/react-vis

Thoughts on viewBox property

Open

#901 opened on 2018年8月16日

GitHub で見る
 (8 comments) (1 reaction) (0 assignees)JavaScript (8,615 stars) (868 forks)batch import
enhancementhelp wanted

説明

I've been experimenting with react-vis components library and modifying it to pass a viewBox property all the way down to the svg element in XYPlot.

The results so far have been quite promising:

  • The elements inside the graph can easily be deployed in relation to each other using the internal coordinate system
  • Sizes can also be expresses in a way consistent with that system
  • The SVG scales appropriately, and it can be combined easily with flexbox.

So my question is: why is it that this doesn't have support out of the box? Is there any drawbacks I'm not noticing.

Thanks.

コントリビューターガイド

技術スタック
javascriptreact
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Knowledge of ReactUnderstanding of SVG viewBox
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Review the XYPlot component in react vis to understand how SVG attributes are currently passed. Examine the viewBox property specification and how it could be integrated. Look for any prior discussion or PR references in the comments. The issue asks for support out of the box, so research the existing prop passing mechanism and propose a minimal implementation.