uber/h3

Inline _isBaseCellPentagon

オープン

#984 opened on 2025/03/09

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)C (585 件のフォーク)github user discovery
help wanted

Repository metrics

Stars
 (6,310 個のスター)
PR merge metrics
 (平均マージ 7d 19h) (30d で 17 merged PRs)

説明

This is a follow-up for https://github.com/uber/h3/pull/968

As discussed in https://github.com/uber/h3/pull/968, it would be nice to inline _isBaseCellPentagon for use in isValidCell (and potentially other spots in the code base).

I couldn't get this working in https://github.com/uber/h3/pull/968 after trying a mixture of inline and extern, so making this ticket to follow up and revisit.

Some notes:

  • maybe benchmark the array of structs vs stuct of arrays in baseCellData

コントリビューターガイド