twitter/finagle

Add com.twitter.finagle.zipkin.core.Endpoint.ipv6

オープン

#526 opened on 2016/07/13

 (6 件のコメント) (0 件のリアクション) (0 人の担当者)Scala (1,435 件のフォーク)batch import
good first issue

Repository metrics

Stars
 (8,864 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

We currently support logging of only IPv4 addresses. Starting with Zipkin 1.4, endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address. https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift#L276

It looks like the most pivotal change is updating com.twitter.finagle.zipkin.core.Endpoint.ipv6

cc @sveinnfannar

コントリビューターガイド