tursodatabase/libsql

Total changes is accumulated per Hrana stream, not connection which is wrong

オープン

#1,512 opened on 2024/06/27

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)C (490 件のフォーク)batch import
buggood first issuehelp wantedremote protocol

Repository metrics

Stars
 (16,744 個のスター)
PR merge metrics
 (PR metrics pending)

説明

We currently implement total_changes() incorrectly for Hrana client-side protocol because we accumulate the changes per stream, but should do it per connection. I merged the incorrect solution as an intermediate step to expose the API to users because fixing this is a bit involved. Hrana does pass connection to stream but turns it into something useless because of the generics trickery there.

コントリビューターガイド