Total changes is accumulated per Hrana stream, not connection which is wrong · tursodatabase/libsql#1512

(0 comments) (0 reactions) (0 assignees)C (16,744 stars) (490 forks)batch import

buggood first issuehelp wantedremote protocol

説明

We currently implement total_changes() incorrectly for Hrana client-side protocol because we accumulate the changes per stream, but should do it per connection. I merged the incorrect solution as an intermediate step to expose the API to users because fixing this is a bit involved. Hrana does pass connection to stream but turns it into something useless because of the generics trickery there.

コントリビューターガイド

技術スタック: c
領域: database
Issue 種別: bug
難度: 4
推定時間: 1-2 days
活動状況: stale
明確さ: clear
前提条件: Familiarity with Hrana protocolRust genericslibSQL internals
初心者向け度: 20
調査方針: Review the current implementation of total changes() in Hrana client side protocol. Examine how the stream accumulates changes and understand why the connection parameter is not used due to generics trickery. Look for existing comments or linked PRs for context, then propose a fix to move accumulation to connection level.