trivago/melody

melody-hooks requires using melody-component for rendering root component

オープン

#76 opened on 2018/11/20

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (37 件のフォーク)auto 404
enhancementgood first issuehelp wanted

Repository metrics

Stars
 (216 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Explain the problem

When trying to mount a root component written using the melody-hooks API, we still need to rely on melody-component in order to render the root component.

Expected Behaviour

There is a way to render a top-level component from melody-hooks without having to rely on melody-component.

import { render } from 'melody-hooks';
import home from './home';

const documentRoot = document.getElementById('root');
render(documentRoot, home, {
    message: 'Welcome to Melody!'
});

Actual Behaviour

The only way to render a top-level melody-hooks component is by using render from melody-component.

import { render } from 'melody-component';
import home from './home';

const documentRoot = document.getElementById('root');
render(documentRoot, home, {
    message: 'Welcome to Melody!'
});

Provide your Environment details

  • melody version: 1.2.0-0

コントリビューターガイド