tmspzz/Rome

Should not print error if the file attempting to delete does not exist for `bcsymbolmap`

Open

#209 opened on 2020年1月13日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)Haskell (771 stars) (54 forks)batch import
enhancementhelp wanted

説明

When doing the first download, it seems like the "Delete of the bcsymbolmap" causes an error to be printed.

Reproduction Steps:

  1. Create a Romefile with Alamofire
  2. Do the build, and upload the files.
  3. Do rome download

** Expected behavior** Will download the needed files and display:

Downloaded Alamofire from: swift5.1.2/Alamofire/iOS/Alamofire.framework-4.8.2.zip
Downloaded Alamofire.dSYM from: swift5.1.2/Alamofire/iOS/Alamofire.framework.dSYM-4.8.2.zip
Downloaded Alamofire.F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap from: swift5.1.2/Alamofire/iOS/F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap-4.8.2.zip
Downloaded Alamofire.3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap from: swift5.1.2/Alamofire/iOS/3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap-4.8.2.zip

Observed behavior:

Downloaded Alamofire from: swift5.1.2/Alamofire/iOS/Alamofire.framework-4.8.2.zip
Downloaded Alamofire.dSYM from: swift5.1.2/Alamofire/iOS/Alamofire.framework.dSYM-4.8.2.zip
Downloaded Alamofire.F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap from: swift5.1.2/Alamofire/iOS/F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap-4.8.2.zip
Error: no such file Carthage/Build/iOS/F8E21C42-AD64-3352-908B-BEE49D235DC3.bcsymbolmap
Downloaded Alamofire.3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap from: swift5.1.2/Alamofire/iOS/3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap-4.8.2.zip
Error: no such file Carthage/Build/iOS/3C52C344-AA08-3AEC-860A-996FC0701512.bcsymbolmap

It looks like in the line:

https://github.com/tmspzz/Rome/blob/3279870fcaac111df5f3a9fd03c10a45c063758c/src/Caches/S3/Downloading.hs#L182

It attempts to delete the file that exists. In the case that the file does not exist, it should just ignore it and not print and error.

Rome version: 0.23.1.61 OS and version: macOS Catalina

コントリビューターガイド

技術スタック
なし
領域
backendclicloud
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Haskell basicsRome codebase structure
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
The issue points to src/Caches/S3/Downloading.hs line 182 where a file deletion occurs and prints an error if the file doesn't exist. Start by reading that file to understand the current deletion logic. The fix is to either check if the file exists before deleting using `doesFileExist` or handle the specific error case. Ensure to maintain backward compatibility. After making the change, test with the reproduction steps provided in the issue.