Unparseable dates should be handled more gracefully · thunderbird/thunderbird-android#8714

(4 comments) (0 reactions) (0 assignees)Kotlin (13,479 stars) (2,734 forks)batch import

good first issuestatus: answeredtype: bug

説明

Checklist

I have used the search function to see if someone else has already submitted the same bug report.
I will describe the problem with as much detail as possible.

App

K-9 Mail

App version

8.2

Where did you get the app from?

Google Play

Android version

Device model

AGM_PAD_P2

Steps to reproduce

Attempt to retrieve a message with an unparseable date.

Expected behavior

Ideally, the message will be retrieved and displayed with some indication of the problem. At a minimum, the message should be ignored.

Actual behavior

An exception is thrown and none of the retrieved messages are displayed.

Logs

01-03 10:59:35.108 14049 14074 E ImapSync: synchronizeMailbox
01-03 10:59:35.108 14049 14074 E ImapSync: com.fsck.k9.mail.MessagingException: Unable to parse IMAP datetime 'Tue, 31 Dec 2024 23:00:02 +9900' 
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.mail.store.imap.ImapList.getDate(ImapList.java:86)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.mail.store.imap.ImapList.getKeyedDate(ImapList.java:76)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.mail.store.imap.RealImapFolder.handleFetchResponse(RealImapFolder.kt:760)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.mail.store.imap.RealImapFolder.fetch(RealImapFolder.kt:623)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.backend.imap.ImapSync.fetchUnsyncedMessages(ImapSync.kt:461)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.backend.imap.ImapSync.downloadMessages(ImapSync.kt:331)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.backend.imap.ImapSync.synchronizeMailboxSynchronous(ImapSync.kt:203)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.backend.imap.ImapSync.sync(ImapSync.kt:34)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.backend.imap.ImapBackend.sync(ImapBackend.kt:56)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.controller.MessagingController.syncFolder(MessagingController.java:638)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.controller.MessagingController.synchronizeMailboxSynchronous(MessagingController.java:578)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.controller.MessagingController.loadMoreMessagesSynchronous(MessagingController.java:542)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.controller.MessagingController.lambda$loadMoreMessages$4(MessagingController.java:526)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.controller.MessagingController.$r8$lambda$R4JompHX5lAPJKWcyY6ODgWeMTs(MessagingController.java:0)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.controller.MessagingController$$ExternalSyntheticLambda21.run(R8$$SyntheticClass:0)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.controller.MessagingController.runInBackground(MessagingController.java:221)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.controller.MessagingController.-$$Nest$mrunInBackground(MessagingController.java:0)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.controller.MessagingController$1.run(MessagingController.java:162)
01-03 10:59:35.108 14049 14074 E ImapSync:      at java.lang.Thread.run(Thread.java:1012)
01-03 10:59:35.108 14049 14074 E ImapSync: Caused by: java.text.ParseException: Unparseable date: "Tue, 31 Dec 2024 23:00:02 +9900"
01-03 10:59:35.108 14049 14074 E ImapSync:      at java.text.DateFormat.parse(DateFormat.java:400)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.mail.store.imap.ImapList.parseDate(ImapList.java:157)
01-03 10:59:35.108 14049 14074 E ImapSync:      at com.fsck.k9.mail.store.imap.ImapList.getDate(ImapList.java:84)
01-03 10:59:35.108 14049 14074 E ImapSync:      ... 18 more
01-03 10:59:35.117 14049 14074 E ImapSync: Failed synchronizing folder xxx@example.com:INBOX @ Fri Jan 03 10:59:35 PST 2025

コントリビューターガイド

技術スタック: kotlinandroid
領域: mobile
Issue 種別: bug
難度: 3
推定時間: half day
活動状況: fresh
明確さ: clear
前提条件: basic Android development
初心者向け度: 60
調査方針: Investigate the date parsing in `ImapList.java`, specifically the `getDate()` and `parseDate()` methods around lines 84-86 and 157. The current implementation throws an exception when a date with an invalid timezone offset (like '+9900') is encountered. To fix this, the parseDate method should catch the `ParseException` and either return a default date (e.g., epoch) or skip the problematic field. Additionally, consider how to propagate a warning to the user through the UI, as suggested in the issue. Look at how other email clients handle similar invalid dates. The fix should be localized to the IMAP parsing layer and should not break existing functionality.