thunderbird/thunderbird-android

Ask for notification permission when enabling account notifications

Open

#7,554 opened on 2024年1月24日

GitHub で見る
 (9 comments) (0 reactions) (0 assignees)Kotlin (13,479 stars) (2,734 forks)batch import
good first issuepriority: medium

説明

Currently the app is only asking for the notification permission during onboarding. But if the user doesn't grant the permission then, the app should ask again when the user enables notifications for an account (either when adding an additional account or via account settings).

We'll also have to handle the case where the user has denied the permission already and point them to the correct Android screen to reverse that decision.

Open question: What should the app do when it notices the notification permission has been revoked, but notifications are enabled inside the app?

コントリビューターガイド

技術スタック
kotlinandroid
領域
mobile
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Android permission modelKotlinThunderbird Android codebase
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
Investigate where notification permission is requested during onboarding (likely in onboarding flow). Find the account settings screen where notifications can be toggled (e.g., AccountSettingsFragment). Implement permission request when user enables notifications. Handle denied permission by showing rationale or directing to system settings. For the open question about revoked permissions, seek clarification from maintainers. Check existing permission handling in NotificationPermissionManager.