theforeman/foremanctl

Review dynflow-sidekiq exec command

オープン

#72 opened on 2025/01/29

 (2 件のコメント) (0 件のリアクション) (0 人の担当者)Python (38 件のフォーク)auto 404
foremangood first issue

Repository metrics

Stars
 (25 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Based on https://github.com/evgeni/talks/pull/4#discussion_r1932083989 we should review the command:

https://github.com/theforeman/foreman-quadlet/blob/177348fc149e74a4adb6680cb239181f16cf8476/roles/foreman/tasks/main.yaml#L90

This copies the DYNFLOW_SIDEKIQ_SCRIPT (that's also set as an env var) and hardcodes the Rails environment, but do we even need to expose this in the first place? It's based on https://github.com/theforeman/foreman/blob/74ddd8851cebd21c268002e0c82a3619d2a9db66/extras/systemd/dynflow-sidekiq%40.service#L12-L20 but is it better to provide a better /usr/libexec/foreman/sidekiq-selinux wrapper script that has these defaults built in?

コントリビューターガイド