thedevdojo/voyager

Validation connected to Settings

Open

#3,494 opened on 2018年8月25日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)PHP (11,817 stars) (2,652 forks)batch import
help wanted

説明

  • Laravel: latest
  • Voyager: latest
  • PHP: 7
  • Database: mysql

Description of problem

Not really a problem, its a feature request.

Proposed solution

n/a

Alternatives considered

n/a

Additional context

As asked here it would be great to have the same validation currently available for Bread also for Settings, this is because you might have users that have to set a number as a settings but turn on adding invalid characters upon setting their settings.

For example we choose a textarea where a customer should typ only numbers, but instead the customer (user) is using text and therefore the input is invalid but did get accepted by the system.

It would be awesome to be able to set de validation variables also for the settings page.

コントリビューターガイド

技術スタック
phplaravelmysql
領域
backend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Familiarity with Laravel validationUnderstanding of Voyager's BREAD systemVoyager development environment
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Examine Voyager's BREAD validation implementation in VoyagerBreadController.php to understand how validation rules are applied. Then, locate the Settings controller (likely VoyagerSettingsController.php) and identify where settings are saved. Add validation logic similar to BREAD, allowing validation rules to be defined for each setting. Check if the settings table has a column for validation rules (e.g., 'validation') and how those rules are used. There is no linked PR or further discussion, so implementation details are open. Consider also reviewing any existing tests for settings to ensure backward compatibility.