testcontainers/testcontainers-java

InternalCommandPortListeningCheck always fails for containers built without `/bin/sh`

Open

#3,317 opened on 2020年10月11日

GitHub で見る
 (5 comments) (7 reactions) (0 assignees)Java (7,535 stars) (1,588 forks)batch import
help wantedtype/bug

説明

Relates to #2984

I'm surprised we've not come across this earlier, but the default TCP port listening detector InternalCommandPortListeningCheck does not work for containers that do not have /bin/sh included.

This predominantly affects images built upon scratch.

The workaround/solution is to use a more application specific WaitStrategy - e.g. an HTTP wait strategy.

However the log messages don't make this easy to realise.

Given that we do both the internal and external port checks for a good reason, I don't think we can just rely on the external port check. Still perhaps we can raise a very specific error message if /bin/sh is not available inside the container.

コントリビューターガイド

技術スタック
javadocker
領域
testing
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
JavaDockerTestcontainers basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
Investigate the InternalCommandPortListeningCheck class in the testcontainers java repository. The issue relates to #2984 and describes that the check fails when /bin/sh is not present inside the container. Consider adding a fallback or a more descriptive error message. Look at how the check currently works and propose a modification to detect the absence of /bin/sh and provide a helpful warning or alternative check.