testcontainers/testcontainers-java

Support container_name in docker-compose file

Open

#2,472 opened on 2020年3月24日

GitHub で見る
 (12 comments) (14 reactions) (0 assignees)Java (7,535 stars) (1,588 forks)batch import
area/docker-composegood first issuehelp wantedresolution/somedaymaybe

説明

docker-compose files which contain container_name are not supported and the creation of DockerComposeContainer fails due to IllegalStateException. This has been introduced in #1151 as a quick fix for unintuitive feedback. If I understand correctly, the option of an implementation was however not discarded, but postponed. This issue is now about the implementation.

コントリビューターガイド

技術スタック
javadocker
領域
backendtesting
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Javatestcontainers internalsdocker compose format
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
The issue requests adding support for the `container name` field in docker compose files when creating a `DockerComposeContainer`. The current behavior throws an `IllegalStateException` due to a quick fix in issue #1151. To implement this, you need to locate the docker compose parsing logic in the testcontainers java codebase, likely in files like `DockerComposeContainer.java` or related parser classes. The implementation should handle `container name` by mapping it appropriately to the container setup. Review the discussion in this issue and #1151 for context. There are no existing PRs, so the solution is open for contribution.
Support container_name in docker-compose file · testcontainers/testcontainers-java#2472 | Good First Issue