tailscale/tailscale

portlist: data race

オープン

#7,520 opened on 2023/03/09

 (7 件のコメント) (0 件のリアクション) (0 人の担当者)Go (2,554 件のフォーク)batch import
help wantedneeds-fix

Repository metrics

Stars
 (31,565 個のスター)
PR merge metrics
 (平均マージ 5d 22h) (30d で 173 merged PRs)

説明

Seen in CI, from https://github.com/tailscale/tailscale/actions/runs/4378413300/jobs/7663124538:

WARNING: DATA RACE
Write at 0x00c004ff2e98 by goroutine 49:
  tailscale.com/ipn/ipnlocal.(*LocalBackend).readPoller()
      tailscale.com/ipn/ipnlocal/local.go:1787 +0x1db
  tailscale.com/ipn/ipnlocal.(*LocalBackend).Start.func1.2()
      tailscale.com/ipn/ipnlocal/local.go:1331 +0x39

Previous read at 0x00c004ff2e98 by goroutine 50:
  tailscale.com/tailcfg.(*Hostinfo).Clone()
      tailscale.com/tailcfg/tailcfg_clone.go:110 +0x71
  tailscale.com/control/controlclient.(*Direct).SetHostinfo()
      tailscale.com/control/controlclient/direct.go:297 +0x119
  tailscale.com/control/controlclient.NewDirect()
      tailscale.com/control/controlclient/direct.go:258 +0x169a
  tailscale.com/control/controlclient.NewNoStart()
      tailscale.com/control/controlclient/auto.go:94 +0x7b
  tailscale.com/control/controlclient.New()
      tailscale.com/control/controlclient/auto.go:85 +0x77
  tailscale.com/ipn/ipnlocal.(*LocalBackend).getNewControlClientFunc.func1()
      tailscale.com/ipn/ipnlocal/local.go:1178 +0x77
  tailscale.com/ipn/ipnlocal.(*LocalBackend).Start()
      tailscale.com/ipn/ipnlocal/local.go:1363 +0x2374
  tailscale.com/ipn/ipnlocal.(*LocalBackend).resetForProfileChangeLockedOnEntry()
      tailscale.com/ipn/ipnlocal/local.go:4798 +0x193
  tailscale.com/ipn/ipnlocal.(*LocalBackend).setClientStatus()
      tailscale.com/ipn/ipnlocal/local.go:906 +0xce4
  tailscale.com/ipn/ipnlocal.(*LocalBackend).setClientStatus-fm()

Similar to #6314

コントリビューターガイド