swiftlang/swift

[SR-8252] Consolidate and Fix -debug-crash-* Flags

オープン

#50,784 opened on 2018/07/13

 (4 件のコメント) (0 件のリアクション) (0 人の担当者)Swift (10,719 件のフォーク)batch import
compilergood first issueimprovement

Repository metrics

Stars
 (69,989 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Previous ID SR-8252
Radar None
Original Reporter @CodaFi
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, StarterBug
Assignee None
Priority Medium

md5: 85fb82c2ea0303f5308473609b79bde5

Issue Description:

Currently, Swift has -debug-crash-immediately and -debug-crash-after-parse and -debug-assert-after-parse. The problem is twofold:

1) -debug-assert-after-parse understands the old hat meaning of "-parse" which used to mean "parse and type check". Now that the compiler understands these are distinct actions, this flag is misnamed.

2) The more useful distinction is crashing immediately versus crashing after a particular phase.

We should generalize -debug-assert and -debug-crash to mean "assert after the current frontend action finishes" or "crash after the current frontend action finishes" respectively. -debug-crash-immediately should still be retained because there needs to be a way to crash argument parsing.

コントリビューターガイド