swiftlang/swift

[SR-1111] Non-optimized builds should avoid redundant thick_to_objc_metatype conversions

オープン

#43,724 opened on 2016/03/30

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Swift (10,719 件のフォーク)batch import
IRGencompilergood first issueimprovementnon-optimized only

Repository metrics

Stars
 (69,989 個のスター)
PR merge metrics
 (平均マージ 8d 17h) (30d で 510 merged PRs)

説明

Previous ID SR-1111
Radar None
Original Reporter @belkadan
Type Improvement
Votes 0
Component/s Compiler
Labels Improvement, IRGen, NotOptimizedOnly, StarterBug
Assignee None
Priority Medium

md5: ee5fa37243b2596a51a6125675863696

Issue Description:

In this code:

import Foundation
func test() -> Bool {
  let a = RunLoop.current
  let b = RunLoop.main
  return a === b
}

We're smart enough to avoid emitting two references to the metadata for NSRunLoop, but not smart enough (in -Onone builds) to avoid emitting the conversion to an ObjC Class twice, which involves a branch. We should be able to reuse the value from the first thick_to_objc_metatype conversion.

コントリビューターガイド