swagger-api/swagger-codegen

[Javascript] Problems on deserialize text type and on file response

Open

#3,297 opened on 2016年7月5日

GitHub で見る
 (5 comments) (0 reactions) (0 assignees)HTML (12,701 stars) (5,474 forks)batch import
Client: JavaScript/Node.jsIssue: Bughelp wanted

説明

Hi, I'm testing my api on the generated nodejs(javascript) client. I've found two problems, that break the client when called. First: when I've a call that return text/plain, SuperAgent initialize the body to {}, so data it's never null and doesn't verify the if condition, and in the end it gives an error. deserialize I've done a fix for my case, just adding this line in the if clauses "if (data == null || (returnType==='String' && Object.keys(data).length === 0 && data.constructor === Object))" but I think this is a bug and has to be correct

Second: I've a call where the response is a file file And this is fine on other language like java or ruby, but not on javascript. It gives this error: file2

Thanks in advance for support

I'm using Swagger-codegen version 2.2.0

コントリビューターガイド

技術スタック
javascriptnodejs
領域
apitooling
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
JavaScriptSuperAgentSwagger codegen
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
The issue reports two bugs in the generated JavaScript client: deserializing text/plain responses where SuperAgent initializes body to {} and file responses causing errors. To fix, examine the JavaScript client template in the swagger codegen repository (likely under modules/swagger codegen/src/main/resources/JavaScript/). For the text/plain case, add a condition to check if returnType is 'String' and data is an empty object. For the file response, ensure proper handling of binary data in the generated code. Check the linked screenshots and comments for more context.