stufro/chordly

Make bin page searchable

オープン

#37 opened on 2025/07/21

 (4 件のコメント) (0 件のリアクション) (0 人の担当者)Ruby (11 件のフォーク)auto 404
good first issue

Repository metrics

Stars
 (60 個のスター)
PR merge metrics
 (PR metrics pending)

説明

I'd like to be able to search list of chord sheets which have been deleted.

Requirements

  • The existing search_controller.js is used to implement the search functionality
    • You can see examples of how this is used on the chord sheet and set list show pages.
    • For example in the chords sheets _library.html.slim partial, the search controller is attached to a div and the input element is configured, then in _chord_sheet.html.slim partial on line 1 we define the target and line 9 define the search term.
  • A cypress test is added in spec/cypress/e2e/chord_sheets.cy.js
    • Run rake cy:open to run tests whilst developing
    • You can define a test with it.only("...") to make cypress just run that 1 test on reload

コントリビューターガイド