stretchr/testify

Should `Equal` pass too when `EqualValues` would pass?

Open

#235 opened on 2015年11月5日

GitHub で見る
 (10 comments) (0 reactions) (0 assignees)Go (1,704 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (25,958 stars)
PR merge metrics
 (平均マージ 6d 15h) (30d で 2 merged PRs)

説明

Right now there are some cases where Equals fails where EqualValues passes. e.g: comparing assert.Equal(t, uint32(5), 5)

However, Equal is a broader term and seems to imply that it would include EqualValues.

I want to consider making Equal pass when EqualValues passes too.

Main thing to research is whether there's any case where that behaviour would translate in an Equal assertion passing when it should be failing.

コントリビューターガイド