streamich/react-use

[useMeasure] Ability to track a custom Ref

Open

#1,227 opened on 2020年5月18日

GitHub で見る
 (15 comments) (19 reactions) (0 assignees)TypeScript (43,979 stars) (3,273 forks)batch import
good first issuehelp wanted

説明

Is your feature request related to a problem? Please describe.

Currently useMeasure returns a ref which needs to be assigned a ref in the JSX. This has 2 issues:

  1. The ref is not a real useRef for eg. Does not have ref.current as a prop.
  2. If I already have a component where I have a ref, I just want to track its size changes.

Describe the solution you'd like

An API of this shape: const {width, height ... } = useMeasure({ref: currentRef});

Describe alternatives you've considered

I am using https://github.com/ZeeCoder/use-resize-observer ... in the absence of the above which I want to remove.

コントリビューターガイド

技術スタック
typescriptreact
領域
frontend
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-2 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
understanding of React refsknowledge of useMeasure hook
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
Examine the current useMeasure implementation in react use (src/useMeasure.ts). The issue requests adding an optional `ref` parameter to the hook, allowing users to pass their own ref for observation. Research how the hook currently creates and returns a ref, and consider modifying it to use a provided ref if given. Ensure cleanup removes the ResizeObserver listener when the ref changes or component unmounts. Look at the comments for any proposed API or concerns. No linked PRs or assignees.