strawberry-graphql/strawberry-django

N+1 queries due to queryset.count() if cache is empty

オープン

#788 opened on 2025/09/30

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)Python (152 件のフォーク)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (496 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Describe the Bug

In a nested ListConnectionWithTotalCount, if the child has total_count in the query, if there is a parent node with no related child nodes, there is a queryset.count() triggered. This leads to N+1 queries like scenario if very few parent nodes have child nodes.

https://github.com/strawberry-graphql/strawberry-django/blob/269954c582dfa38dc93af95abd2a275888f50103/strawberry_django/pagination.py#L269-L298

Instead, if the queryset is optimized (is_optimized_by_prefetching is True) and there is no offset / limit mentioned then it should just return 0 assuming no nodes were found, calling the count() method only for unoptimized querysets.

コントリビューターガイド