storybookjs/storybook

[Bug]: automigrate fails on EXDEV error

Open

#30,184 opened on 2025年1月3日

GitHub で見る
 (5 comments) (2 reactions) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
automigrationsbughelp wantedwindows

説明

Describe the bug

Running the command automigrate on windows, it tries to move the logfile from user's temp folder to the current project folder by renaming it. This fails, if temp folder and project folder are on different drives/partitions with the error: Error: EXDEV: cross-device link not permitted, rename 'C:\Users\[USER]\AppData\Local\Temp\435cc8918d4e493a2eb400fc4351782f\migration-storybook.log' -> '.\migration-storybook.log'

Reproduction link

NONE

Reproduction steps

No response

System

Storybook Environment Info:

  System:
    OS: Windows 11 10.0.22631
    CPU: (16) x64 AMD Ryzen 7 PRO 7840U w/ Radeon 780M Graphics
  Binaries:
    Node: 22.12.0 - C:\Program Files\nodejs\node.EXE
    npm: 11.0.0 - ~\AppData\Roaming\npm\npm.CMD <----- active
  Browsers:
    Edge: Chromium (128.0.2739.79)
  npmPackages:
    @storybook/addon-a11y: ^8.4.7 => 8.4.6
    @storybook/addon-coverage: ^1.0.4 => 1.0.4
    @storybook/addon-docs: ^8.4.7 => 8.4.6
    @storybook/addon-essentials: ^8.4.7 => 8.4.6
    @storybook/addon-interactions: ^8.4.7 => 8.4.6
    @storybook/addon-jest: ^8.4.7 => 8.4.6
    @storybook/addon-links: ^8.4.7 => 8.4.6
    @storybook/angular: ^8.4.7 => 8.4.6
    @storybook/core-server: ^8.4.7 => 8.4.6
    @storybook/test-runner: 0.19.0 => 0.19.0
    storybook: ^8.4.7 => 8.2.8
  npmGlobalPackages:
    @storybook/cli: 8.4.7

Additional context

No response

コントリビューターガイド

技術スタック
typescriptnodejs
領域
cli
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Node.js file systemStorybook automigrate
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
Investigate the automigrate utility in the Storybook core server package. Locate where the log file is being moved using `fs.rename` (likely in `lib/core server/src/utils/automigrate.ts` or similar). Replace `fs.rename` with a cross device safe copy and delete approach (e.g., using `fs.copyFile` and `fs.unlink`). Ensure to handle edge cases where the source and destination are on the same device (the rename can still be used for performance). Check existing tests and consider adding a test for cross device scenarios.