storybookjs/storybook

[Bug]: optimizePackageImports do not work in @storybook/nextjs

Open

#30,126 opened on 2024年12月23日

GitHub で見る
 (2 comments) (1 reaction) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
bughelp wantednextjssev:S3

説明

Describe the bug

Some server code exported from barrel file. It works in nextjs itself because of optimizePackageImports, but fails to resolve some node packages in storybook.

Reproduction link

https://stackblitz.com/edit/github-dvxhuih6-cb6t3t3m?file=src%2Fshared%2Findex.ts

Reproduction steps

No response

System

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm <----- active
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @storybook/addon-essentials: ^8.5.0-beta.4 => 8.5.0-beta.4 
    @storybook/addon-interactions: ^8.5.0-beta.4 => 8.5.0-beta.4 
    @storybook/addon-onboarding: ^8.5.0-beta.4 => 8.5.0-beta.4 
    @storybook/blocks: ^8.5.0-beta.4 => 8.5.0-beta.4 
    @storybook/nextjs: ^8.5.0-beta.4 => 8.5.0-beta.4 
    @storybook/react: ^8.5.0-beta.4 => 8.5.0-beta.4 
    @storybook/test: ^8.5.0-beta.4 => 8.5.0-beta.4 
    storybook: ^8.5.0-beta.4 => 8.5.0-beta.4

Additional context

No response

コントリビューターガイド

技術スタック
typescriptnextjsreact
領域
frontendtesting
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Next.jsStorybookTypeScriptbarrel files
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
This bug occurs because optimizePackageImports from Next.js is not applied in Storybook's webpack configuration, causing server side code to fail when imported from barrel files. To address, investigate how @storybook/nextjs merges the user's next.config.js (especially the experimental.optimizePackageImports field) into its own webpack config. The reproduction at StackBlitz shows the setup; check the shared/index.ts and see how the error arises. Look at the code in packages/storybook nextjs that handles webpack configuration merging, particularly the part that should respect nextConfig.experimental.optimizePackageImports. A potential fix would be to ensure that optimization is included in the final webpack config used by Storybook.