storybookjs/storybook

[Bug]: experimental_indexers ignores importPath

Open

#25,554 opened on 2024年1月10日

GitHub で見る
 (15 comments) (0 reactions) (1 assignee)TypeScript (89,909 stars) (10,058 forks)batch import
buggood first issuehelp wantedsev:S3story index

説明

Describe the bug

In the experimental indexer docs it says that an indexer can specify an importPath to a target CSF file, but doing so has no effect. Looking at the source code it looks like the importPath returned from an indexer is not used and instead the input source to the indexer will always be used as the importPath.

To Reproduce

https://github.com/storybookjs/storybook/blob/e942e71e1f5281f9197faab6d61625b0ac8cecfd/code/lib/core-server/src/utils/StoryIndexGenerator.ts#L302

System

Storybook Environment Info:

  System:
    OS: macOS 14.2.1
    CPU: (10) arm64 Apple M1 Pro
    Shell: 5.1.16 - /opt/homebrew/bin/bash
  Binaries:
    Node: 20.10.0 - ~/.nvm/versions/node/v20.10.0/bin/node
    Yarn: 4.0.2 - ~/.nvm/versions/node/v20.10.0/bin/yarn <----- active
    npm: 10.2.3 - ~/.nvm/versions/node/v20.10.0/bin/npm
  Browsers:
    Chrome: 120.0.6099.109
    Edge: 120.0.2210.121
    Safari: 17.2.1

Additional context

No response

コントリビューターガイド

技術スタック
typescriptnodejs
領域
backendtooling
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
active
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
TypeScript basicsUnderstanding of Storybook's indexer concept
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
The bug is that experimental indexers ignore the importPath specified in the indexer configuration, and instead always use the input source as the importPath. The relevant code is in StoryIndexGenerator.ts around line 302. To fix this, examine how the indexer's returned importPath is handled and ensure it is used instead of the input source. Check the indexer documentation and the type definitions for experimental indexers to understand the expected behavior. Look at the function that processes indexers and verify where the importPath from the result is applied. The fix likely involves updating the logic to use the returned importPath when present.
[Bug]: experimental_indexers ignores importPath · storybookjs/storybook#25554 | Good First Issue