storybookjs/storybook

[Feature Request]: CSF3 Autofixer shouldn't hoist arg uses above declarations

オープン

#21,488 opened on 2023/03/08

 (2 件のコメント) (0 件のリアクション) (0 人の担当者)TypeScript (10,058 件のフォーク)batch import
bugcodemodshelp wantedsev:S3

Repository metrics

Stars
 (89,909 個のスター)
PR merge metrics
 (平均マージ 7d 22h) (30d で 184 merged PRs)

説明

Is your feature request related to a problem? Please describe

When migrating a story defined like:

export const MyStory = (props) => <MyComponent {...props} />
const defaultArgs = { foo: 'bar'}
MyStory.args = defaultArgs

using the args is hoisted above the constant definition:

export const MyStory = {
  render: (props) => <MyComponent {...props} />,
  args: defaultArgs,
}
const defaultArgs = { foo: 'bar'}

Describe the solution you'd like

Ideally the codemod would move the constant declaration above where it was used:

const defaultArgs = { foo: 'bar'}
export const MyStory = {
  render: (props) => <MyComponent {...props} />,
  args: defaultArgs,
}

Describe alternatives you've considered

I looked, but there's not an autofixer for this in eslint or ts. I can check to see if theres an existing codemod that can help with this.

Are you able to assist to bring the feature to reality?

yes, I can

Additional context

No response

コントリビューターガイド