storybookjs/storybook

[Feature Request]: Drop dependency on `browser-assert`

Open

#21,408 opened on 2023年3月6日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)TypeScript (89,909 stars) (10,058 forks)batch import
help wantedmaintenancesecurity

説明

Is your feature request related to a problem? Please describe

The package browser-assert which @storybook/builder-manager and @storybook/builder-webpack5 depend on has various issues according to: https://socket.dev/npm/package/browser-assert

Describe the solution you'd like

Remove the unmaintained dependency and write the 7 LOC yourself or use native methods.

Describe alternatives you've considered

No response

Are you able to assist to bring the feature to reality?

no

Additional context

No response

コントリビューターガイド

技術スタック
typescriptnodejs
領域
developer experiencetooling
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
JavaScriptnpm dependency managementStorybook project structure
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
80
調査方針
Locate the dependency declaration of `browser assert` in the package.json files of `@storybook/builder manager` and `@storybook/builder webpack5`. Search for imports of `browser assert` in the source code of these packages. Implement a small function that replicates the 7 line functionality (likely a simple boolean check for browser context). Remove the dependency from package.json and run the tests to ensure nothing breaks. The issue has 1 comment; check it for any additional guidance. If the replacement is straightforward, submit a PR removing the dependency.