stan-dev/stan

Remove unused variational::base_family class

オープン

#1,695 opened on 2015/11/19

 (6 件のコメント) (0 件のリアクション) (1 人の担当者)C++ (387 件のフォーク)batch import
code cleanupgood first issue

Repository metrics

Stars
 (2,761 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

The base class variational::base_family has no virtual methods and the one function it does define uses no member variables or functions, so can be made standalone outside of the class. Therefore, base_family should be removed.

  • remove src/stan/variational/base_family.hpp
  • move function write_error_msg_() into its own file and rename without suffix _
  • patch families/normal_meanfield.hpp and families/normal_fullrank.hpp:
    • remove references to base_family
    • change calls to write_error_msg_ to include and call new function

If the intent was to somehow pull down some of the functionality from the subclasses, then this issue should be repurposed to do that.

コントリビューターガイド