stan-dev/stan

Remove unused variational::base_family class

Open

#1,695 opened on 2015年11月19日

GitHub で見る
 (4 comments) (0 reactions) (1 assignee)R (1,476 stars) (270 forks)batch import
code cleanupgood first issue

説明

The base class variational::base_family has no virtual methods and the one function it does define uses no member variables or functions, so can be made standalone outside of the class. Therefore, base_family should be removed.

  • remove src/stan/variational/base_family.hpp
  • move function write_error_msg_() into its own file and rename without suffix _
  • patch families/normal_meanfield.hpp and families/normal_fullrank.hpp:
    • remove references to base_family
    • change calls to write_error_msg_ to include and call new function

If the intent was to somehow pull down some of the functionality from the subclasses, then this issue should be repurposed to do that.

コントリビューターガイド

技術スタック
cpp
領域
backend
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
C++Stan code organization
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
The issue specifies three tasks: remove src/stan/variational/base family.hpp, create a new file for write error msg () without the underscore suffix, and update families/normal meanfield.hpp and families/normal fullrank.hpp to remove base family references and call the new function. The main question from the issue is whether the base family class was intended to pull down functionality from subclasses, which should be clarified with maintainers. The files are in the stan/variational directory.