spring-cloud/spring-cloud-netflix
GitHub で見るRequestSpecificRetryHandler retries same server for SERVER_THROTTLED
Open
#2,585 opened on 2017年12月27日
help wanted
Repository metrics
- Stars
- (4,805 stars)
- PR merge metrics
- (平均マージ 3h 47m) (30d で 5 merged PRs)
説明
Netflix's RequestSpecificRetryHandler allows to retry on same server for SERVER_THROTTLED error.
When the okToRetryOnAllErrors property is true, the retry handler allows to retry on the same server unconditionally without taking into account the actual error. This is useless when the server responded with SERVER_THROTTLED.
It looks like the if statement at https://github.com/Netflix/ribbon/blob/master/ribbon-core/src/main/java/com/netflix/client/RequestSpecificRetryHandler.java#L58-L65 should be considered first before the other conditions.
I doubt Netflix is willing to change this behavior but we could override it in SpringCloud. What do you think ?