spring-cloud/spring-cloud-gateway

Modify Request Body for a GET request

Open

#1,147 opened on 2019年7月3日

GitHub で見る
 (7 comments) (0 reactions) (0 assignees)Java (4,284 stars) (3,204 forks)batch import
enhancementhelp wanted

説明

We currently have custom code for modifying request body which works but I want to move to the standard ModifyRequestBodyGatewayFilterFactory.

We have a scenario where Spring Cloud Gateway received a GET request and we need call an internal GraphQL api with a POST and a request body.

ModifyRequestBodyGatewayFilterFactory works great if there is a body present in the original request but doesn't apply the rewriteFunction when there is no body on GET requests.

I am using v2.1.2.RELEASE and I have hacked together a change to ModifyRequestBodyGatewayFilterFactory which works for me:

Mono<?> modifiedBody = serverRequest.bodyToMono(inClass)
        .defaultIfEmpty("") //added this line
        .flatMap(o -> config.rewriteFunction.apply(exchange, o));

I appreciate that the ModifyRequestBodyGatewayFilterFactory is beta, but would it be possible to support adding a body for GET requests in the future?

コントリビューターガイド

技術スタック
javaspringgraphql
領域
backendapi
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
JavaSpring Cloud GatewayReactive programming
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
30
調査方針
Examine the current implementation of `ModifyRequestBodyGatewayFilterFactory` in the spring cloud gateway repository. The user's proposed fix is to add `.defaultIfEmpty("")` in the `filter` method to allow body rewriting when original request body is empty (typical for GET requests). Implement this change and ensure it does not break existing behavior for POST requests with a body. Write unit tests covering both scenarios and verify the filter works with the standard `ModifyRequestBodyGatewayFilterFactory`. Refer to the linked issue for additional context on the expected behavior.