spotify/reactochart

resolvers in `resolveXYScale` should recursively traverse `children` tree

オープン

#36 opened on 2017/01/06

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)JavaScript (50 件のフォーク)auto 404
help wanted

Repository metrics

Stars
 (554 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

The new code in 0.2.1 is improving but has a significant regression - All of the resolvers in resolveXYScales used to recursively check the component's children to find the necessary props. However @thehindenburg 's new mapOverChildren, while being a nicer abstraction, does not do recursion - it only maps over an element's direct children.

Recursion is necessary IMHO because we want to support the use case of the user having intermediate layer components between XYPlot and their charts, eg.:

<XYPlot>
  <CustomChartWrapper>
    <LineChart />
    <AreaChart />
    <BarChart />
  </CustomChartWrapper>
</XYPlot>

Without recursion, this would never try to resolve anything on the actual chart components, it would stop at CustomChartWrapper. We should improve the general resolution functions in resolveXYScales to handle this case

コントリビューターガイド